- Jan 15, 2021
-
-
Zoey76 authored
Implemented effect InstantDispelByName. Implemented target handler Enemy Not. Implemented target handler Target. Added missing mpConsume1. Added hitCancelTime. Changed to targetType TARGET. Added missing affectScope. Split multiple effects in several effects. Added official-like operate conditions. Official like GM skills. Implemented 84 missing or broken skills. Updated over 500 skills t match High Five official values. Added missing skills: Reducing P. Def Stun (4600) NPC Monster Hate (4697) NPC - Ultra Bomb (5039) NPC Remove Death Penalty (5077) Stun (5112) Presentation - Balor 10 (5410) Presentation - Balor 11 (5411) Presentation - Balor 12 (5412) Invincible Blow (5419) Presentation - Gathering of Evil Power (5433) Increase Recovery Rate (5436) NPC Full Recover (5457) Paralysis (5459) Fear (5460) Endurance Defense Up (5484) Endurance Defense Up (5485) Endurance Offense Up (5486) Counter Critical Damage Up (5488) Counter Critical Rate Up (5489) Fungus Hub (6623) Shock (6624) Energy of Enchant (6632) Energy of Casting Speed (6634) Vampiric Aura (6637) Presentation - Ice Knight (6647) Komodo Heal (6648) Tarsque Carapace (6655) Lavasaurus Firstborn Attack (6656) Lavasaurus Firstborn Heal (6657) Feral Shield (6666) Feral Wind Walk (6667) Feral Death Whisper (6668) Feral Body Bless (6669) Feral Vampiric Rage (6670) Feral Berserker Spirit (6671) Feral Bless Shield (6672) Presentation - Attain Noblesse (6673) Lavasaurus Firstborn Attack (6675) Absorb HP MP (6689) Ball Trapping Gnosian Agathion Cute Trick (6699) Resist Holy of Elcadia (6729) Etis Shadow (6731) Antharas's Stigma (6733) Energy of Destruction (6734) Petrify (6735) Blow Attack (6751) Power Strike (6844) Energy Abundance Effect (6883) Morale Boost (6884) Test - Charge (7065) Test Stun Charge (7066) Test Range Charge (7067) Test Steal Abnormal State(7068) Test Abnormal State DD (7069) Test - Soul Transfer (7071) Beast Training - Release (8362) Christmas Festival (23017) Reset Consecutive Wins (23023) Jack's game - Target (23122) Gwanseum Nyang Nyang Agathion Special Skill - Blessing of Mercy (23126) Blue Opera Agathion Special Skill - Sword of Recovery (23128) Blue Opera Agathion Special Skill - Sword of Water (23129) Red Opera Agathion Special Skill - Spear of Flames (23131) Prominent Outsider Adventurer's Ability (23153) Hand of Warmth (23155) Gift of Thanks (23156) Donateloph's Blessing (23157) Raphaeloph's Blessing (23158) Leonardoph's Blessing (23159) Michelangeloph's Blessing (23160) Rudolph Girl's Blessing - Maintain Vitality (23161) Turkey's Big Mistake (23163) Opera Agathion Special Skill - Sword of Life (23164) Inadequate Affection (23165) Energized Rose Spirit (23166) Rosy Seduction (23167) Critical Seduction (23168) Mesmerization (23169) Mesmerization (23170) Narrow Escape (23174) Soul Stealth (23175) Hide (23176) Soul Stealth (23177) Soul Stealth (23178) Updated skills: Sacrifice (69) Divine Blessing (262) Shift Target (489) Light of Heal (567) Divine Rogue Agility (690) Divine Healer Major Heal (698) Divine Healer Battle Heal (699) Divine Healer Group Heal (700) Divine Healer Resurrection (701) Divine Healer Clans (702) Sacrifice Healer (703) Divine Enchanter Water Spirit (704) added missing effects. Divine Enchanter Fire Spirit (705) Divine Enchanter Wind Spirit (706) Divine Enchanter Hero Spirit (707) Zaken Vampiric Rage (719) Heretic Heal (738) Heretic Battle Heal (739) Veil Master Dark Cure (745) Doll Blader Clairvoyance (754) Dread Pool (774) Sharp Edge (825) Spike (826) Restring (827) Case Harden (828) Hard Tanning (829) Embroider (830) Might (871) Empower (875) Star Stone Gathering (932) Special Motion (941) Special Motion (942) Special Motion (943) Special Motion (944) Magician's Will (945) Special Motion (966) Challenge for Fate (985) Soul Shield (1010) Heal (1011) Cure Poison (1012) Recharge (1013) Battle Heal (1015) Purify (1018) Vitalize (1020) Invigor (1032) Resist Poison (1033) Mental Shield (1035) Shield (1040) Regeneration (1044) Empower (1059) Berserker Spirit (1062) Might (1068) Focus (1077) Concentration (1078) Major Heal (1401) Cleanse (1409) Salvation (1410) Mystic Immunity (1411) Celestial Shield (1418) Protection from Darkness (1442) Dark Weapon (1443) Pride of Kamael (1444) Mana Gain (1460) Fire Weapon (1463) Ice Weapon (1464) Wind Weapon (1465) Earth Weapon (1466) Soul Sucking (1472) Erase Mark (1475) Restoration Impact (1488) Flame Armor (1492) Improved Combat (1499) Improved Magic (1500) Improved Condition (1501) Improved Critical Attack (1502) Improved Shield Defense (1503) Improved Movement (1504) Lord of Vampire (1507) Soul Cleanse (1510) Blessed Blood (1531) Counter Critical (1542) Soul Sucking (1545) Resist Earth (1548) Chain Heal (1553) Scroll: Cancel Sleep (2170) Petrifaction Scroll (2239) Hot Spring Nectar (2240) Hot Spring Mineral Water (2241) Hot Spring Fountain Water (2242) Hot Spring Sulfur (2243) Presentation - Collect Items (2630) Wild Magic (2890) Forgiveness (3261) Heal Queen Ant1 (4020) Queen Ant (4021) Body of Nurse Ant (4022) Body of Royal Guard Ant (4023) Heal Queen Ant2 (4024) Master Recharge (4025) Gludio Flame (4026) Gludio Heal (4027) NPC Might (4028) NPC Shield (4029) NPC Clan Might (4030) NPC Clan Aegis (4031) Partisan Heal (4044) NPC Dash (4048) Cubic Heal (4051) NPC Heal (4065) Decrease Atk. Spd. (4070) NPC Haste (4074) Dark Heal (4080) NPC Bear Spirit Totem (4089) NPC Wolf Spirit Totem (4090) NPC Ogre Spirit Totem (4091) NPC Puma Spirit Totem (4092) NPC Hawkeye (4096) NPC Chant of Life (4097) Silence (4098) NPC Berserk (4099) NPC Prominence (4100) NPC Spinning Slash (4101) Surrender To Fire (4102) NPC Ultimate Evasion (4103) Aden Heal (4115) Reduction in recovery time (4126) Baium: General Attack (4127) Stun (4131) Spear: Pound the Ground (4132) Angel Heal (4133) Seal Skill (4134) Baium Heal (4135) Contract Payment (4140) Decrease P. Atk. (4145) Decrease P. Def. (4146) Area Dispel (4147) Poison (4148) Bleed (4149) Flame (4150) Decrease Atk. Spd. (4162) NPC Self-Damage Shield (4163) Paralysis (4164) BOSS Might (4173) BOSS Shield (4174) BOSS Haste (4175) BOSS Reflect Damage (4176) BOSS Heal (4209) BOSS Chant of Life (4210) Increase Rage Might (4317) Ultimate Buff (4318) Adventurer's Wind Walk (4322) Adventurer's Shield (4323) Adventurer's Bless the Body (4324) Adventurer's Vampiric Rage (4325) Adventurer's Regeneration (4326) Adventurer's Haste (4327) Adventurer's Bless the Soul (4328) Adventurer's Acumen (4329) Adventurer's Concentration (4330) Adventurer's Empower (4331) Mental Aegis (4332) Resist Dark Attack (4333) SSQ Cancel (4334) Adventurer's Life Cubic (4338) Mimir's Elixir (4339) Ultimate Buff, 2nd (4340) Ultimate Buff, 3rd (4341) Wind Walk (4342) Decrease Weight (4343) Shield (4344) Might (4345) Mental Shield (4346) Blessed Body (4347) Blessed Soul (4348) Magic Barrier (4349) Resist Stun (4350) Concentration (4351) Berserker Spirit (4352) Bless Shield (4353) Vampiric Rage (4354) Acumen (4355) Empower (4356) Haste (4357) Guidance (4358) Focus (4359) Death Whisper (4360) Curse of Destruction (4361) Curse of Destruction (4362) Curse of Destruction (4363) Blessing of Revelations (4364) Blessing of Revelations (4365) Blessing of Prophecy (4366) Clan Hall Manager Buff (4367) Clan Hall Manager Buff (4368) Clan Hall Manager Buff (4369) Clan Hall Manager Buff (4370) Clan Hall Manager Buff (4371) Clan Hall Manager Buff (4372) Clan Hall Manager Buff (4373) Clan Hall Manager Buff (4374) Clan Hall Manager Buff (4375) Strong Resistance to P. Atk. (4376) Wield Temper (4377) Self Damage Shield (4378) Resist Spear Weapons (4379) Arena: CP Recovery (4380) Magic Skill Block (4381) Curse of Lake Ghost (4382) NPC Hate Stone (4383) Scapegoat's Grace (4384) Scapegoat's Grace (4385) Scapegoat's Grace (4386) Scapegoat's Grace (4387) Resist Paralysis Attacks (4388) Resist Mental Attacks (4389) NPC Abnormal Immunity (4390) Wind Walk (4391) Shield (4392) Might (4393) Blessed Body (4394) Blessed Soul (4395) Magic Barrier (4396) Berserker Spirit (4397) Bless Shield (4398) Vampiric Rage (4399) Acumen (4400) Empower (4401) Haste (4402) Guidance (4403) Focus (4404) Death Whisper (4405) Agility (4406) Area Buff - Wind Walk (4468) NPC Spoils (4470) Area Heal - Per (4474) Perfect Resist Bleeding (4475) Silent Move (4476) Ice Fairy Resist Cold (4479) Ice Fairy Curse Gloom (4480) Ice Fairy Hex (4481) Ice Fairy Silence (4482) Hold (4483) Eating Follower Heal (4484) Eating Follower (4485) NPC Debuff Shield Slow (4493) Orfen Heal (4516) Eye of Assassin (4522) Quest - BOSS Inc HP to Summoned (4527) Quest - BOSS Movement to Summoned (4528) Dance of Resistance (4533) Dance of Nihil (4534) Dance of Weakness (4535) Song of Seduce (4536) Song of Sweet Whisper (4537) Song of Temptation (4538) Curse of Vague (4539) Curse of Weakness (4540) Curse of Nihil (4541) Quest - Commune to Slate (4546) Gaze of Watcher (4547) Quest - Dispel Watcher Gaze (4548) Quest - Unsealed Altar (4549) Quest - Cursed Altar (4550) Hot Springs Rheumatism (4551) Hot Springs Cholera (4552) Hot Springs Flu (4553) Hot Spring Malaria (4554) NPC Resist Mutant (4555) Dispel Hot Spring Disease A_D (4556) Dispel Hot Spring Disease B_D (4557) Dispel Hot Spring Disease C_D (4558) Hot Spring Illusion (4559) Fake Petrificiation (4616) Dispel Petrification (4617) NPC Dispel Sleep (4619) Decrease HP Regeneration Rate (4624) Decrease Speed (4625) NPC Buff - Physical Barrier (4626) NPC Buff - Magical Barrier (4627) Mysterious Aura (4628) NPC MR - HP Drain (4629) NPC MR - Twister (4630) NPC Buff - Acumen Shield WildMagic (4631) NPC Buff - Acumen Empower WildMagic (4632) NPC Buff - Acumen Empower Berserk (4633) NPC Buff - Acumen Empower DamageShield (4634) NPC Buff - Acumen Berserk WildMagic (4635) NPC Buff - Acumen Berserk DamageShield (4636) NPC Buff - Acumen WildMagic DamageShield (4637) Area Buff - Haste (4644) Area Buff - Focus (4645) Area Buff - Death Whisper (4646) Area Buff - Might (4647) Area Buff - Shield (4648) AV - Teleport (4671) NPC Corpse Remove (4672) Valakas Lava Skin (4680) Valakas Tail Stomp (4687) Valakas Regeneration (4691) Quest BOSS Big Body (4692) Quest BOSS Dispel Big Body (4693) Ultimate Debuff (4694) Ultimate Debuff (4695) Ultimate Debuff (4696) Area Buff - HP Regeneration (4698) Blessing of Queen (4699) Shade Sacrifice (4707) Wild Defense (4711) Bright Heal (4713) Heal Trick (4717) Greater Heal Trick (4718) BOSS Heal (4779) BOSS Heal (4780) BOSS Heal (4781) BOSS Heal (4782) BOSS Heal (4783) BOSS Chant of Life (4784) BOSS Chant of Life (4785) BOSS Chant of Life (4786) BOSS Chant of Life (4787) BOSS Chant of Life (4788) Frintezza's Ghost Summoning (5005) NPC - Healing Potion (5040) Charm of Courage (5041) Representation - Enter the Sailren Nest Quest (5089) Sailren Production (5090) Production - Clan / Transfer (5103) Production - Clan Gate (5109) Blessing of Protection (5182) Pet Haste (5186) Pet Vampiric Rage (5187) Pet Regeneration (5188) Pet Blessed Body (5189) Pet Blessed Soul (5190) Pet Guidance (5191) Pet Wind Walk (5192) Pet Acumen (5193) Pet Empower (5194) Pet Greater Heal (5195) Pet Wind Shackle (5196) Pet Hex (5197) Pet Slow (5198) Pet Curse Gloom (5199) Pet Concentration (5201) Boss Regeneration (5205) Event Wind walk (5208) Event Shield (5209) Event Bless the body (5210) Event Vampiric rage (5211) Event Regeneration (5212) Event Haste (5213) Event Bless the soul (5214) Event Acumen (5215) Event Concentration (5216) Event Empower (5217) Production: Event Teleport (5218) Physical Up (5244) Magical Up (5245) Heat of Desert (5399) Presentation - Balor 4 (5404) Presentation - Demonic 1 (5405) Presentation - Demonic 2 (5406) Presentation - Crystalline Golem 1 (5407) Presentation - Crystalline Golem 2 (5408) Presentation - Crystalline Golem 3 (5409) Performing Agathion - Beast Farm (5413) Balor Invincible Removal (5480) Naia Production (5493) Chain Buff - Power Up (5519) Chain Buff - Vampiric Shield (5520) Chain Buff - Critical Sense (5521) Chain Magic - Dark Explosion (5522) Chain Magic - Unholy Castle (5523) Chain Buff - Resistance to Bow and Magic attacks (5524) Chain Buff - Resistance to Melee Attacks (5525) Challenger's Blessing (5526) Flame Armor (5567) Frost Armor (5568) Major Heal (5835) Maguen Plasma (6620) Maguen Plasma (6621) Shock (6622) Energy of Life (6625) Energy of Mana (6628) Energy of Power (6631) Energy of Attack Speed (6633) Energy of Crt Rate (6635) Energy of Speed (6636) Aura of Mystery (6638) Bane of Auras - Damage (6639) Vitalizing Aura (6640) Treykan Transformation (6649) Level 85 Raid Boss (6652) Level 85 Raid Boss (6653) Level 85 Raid Boss (6654) Energy of Range Increment (6674) Magician's Perversity (6676) Maguen Speed Walk (6681) Elite Maguen Speed Walk (6682) Maguen Recall (6683) Maguen Party Recall (6684) Santa Claus's Gift (6685) Sacred Protector Cancel (6686) Patience (6687) Soup of Failure (6688) Presentation - Quest Done (6696) Eternal Blizzard (6697) Pillar of Frozen - Eternal Ice (6698) Wind Walk of Elcadia (6714) Haste of Elcadia (6715) Might of Elcadia (6716) Berserker Spirit of Elcadia (6717) Death Whisper of Elcadia (6718) Guidance of Elcadia 6719 Focus of Elcadia (6720) Empower of Elcadia (6721) Acumen of Elcadia (6722) Concentration of Elcadia (6723) Greater Heal of Elcadia (6724) Bless the Blood of Elcadia (6725) Bless the Blood (6726) Vampiric Rage of Elcadia (6727) Recharge of Elcadia (6728) Greater Battle Heal of Elcadia (6730) Summon Subordinate (6841) Enhance (6842) Morale Boost (6885) NPC Default (7000) Dispel Buff (7001) Dispel Debuff (7002) Dispel All (7003) Master's Blessing - Focus (7041) Master's Blessing - Death Whisper (7042) Master's Blessing - Haste (7043) Master's Blessing - Guidance (7044) Master's Blessing - Blessed Body (7045) Master's Blessing - Blessed Soul (7046) Master's Blessing - Agility (7047) Master's Blessing - Acumen (7048) Master's Blessing - Decrease Weight (7049) Master's Blessing - Might (7050) Master's Blessing - Shield (7051) Master's Blessing - Magic Barrier (7052) Master's Blessing - Vampiric Rage (7053) Master's Blessing - Empower (7054) Master's Blessing - Wind Walk (7055) Master's Blessing - Berserker Spirit (7056) Master's Blessing - Greater Might (7057) Master's Blessing - Greater Shield (7058) Master's Blessing - Wild Magic (7059) Master's Blessing - Clarity (7060) Master's Blessing - Prophecy of Water (7061) Master's Blessing - Prophecy of Fire (7062) Master's Blessing - Prophecy of Wind (7063) Master's Blessing - Chant of Victory (7064) Master's Blessing - Improve Combat (7088) Master's Blessing - Improve Magic (7089) Master's Blessing - Improve Condition (7090) Master's Blessing - Improve Critical (7091) Master's Blessing - Improve Shield Defense (7092) Master's Blessing - Improve Movement (7093) Master's Blessing - Sharpen Edge (7094) Master's Blessing - Face Harden (7095) Master's Blessing - Blessing of Noblesse (7096) Awful Soup (9075) Freesia Bouquet - Event (9150) Baby's Breath Bouquet - Event (9151) Pink Lady - Event (9152) June Bug - Event (9153) Soft Cheese Cake - Event (9154) Freshly-Baked Baguette - Event (9155) Sweet Cream-filled Bread - Event (9156) White Day Candy - Event (9157) Baby Food Skill (22126) Scissors (23019) Start attacking the Turkey (23020) Turkey's Attack Scissors (23021) First win (23022) Switch State (23073) Icy Air Explosion (23074) Jack O'Lantern Card - Confirm Skill (23094) Rotten Jack O'Lantern Card - Confirm Skill (23095) Halloween Defeat (23096) First win (23097) 2nd Consecutive Win (23098) 3rd Consecutive Win (23099) 4th Consecutive Win (23100) 5th Consecutive Win (23101) 6th Consecutive Win (23102) 7th Consecutive Win (23103) 8th Consecutive Win (23104) 9th Consecutive Win (23105) 10th Consecutive Win (23106) 11th Consecutive Win (23107) 12th Consecutive Win (23108) 13th Consecutive Win (23109) 14th Consecutive Win (23110) 15th Consecutive Win (23111) 16th Consecutive Win (23112) 17th Consecutive Win (23113) 18th Consecutive Win (23114) 19th Consecutive Win (23115) 20th Consecutive Win (23116) Frozen Corpse Agathion Cute Trick (23117) Gwangong Agathion Cute Trick (23123) Ladder Snow Agathion Cute Trick (23139) Kadomas Special Skill - Fireworks (23154) Rudolph Girl's Blessing - Replenish Energy (23162) Phoenix Agathion Cute Trick (23171) Phoenix Agathion Special Skill - Nirvana Cycle (23172) Phoenix Agathion Special Skill - Mountain Echoes (23173)
-
- Dec 21, 2020
-
-
Zoey76 authored
Read https://shipilev.net/blog/2016/arrays-wisdom-ancients/ if you are in for some arcane magic.
-
- Apr 27, 2020
- Mar 05, 2019
-
-
Zoey76 authored
Moved to Maven instead of Gradle. Using proper project structure and package structure.
-
- Feb 06, 2019
-
-
Zoey76 authored
-
- Jan 18, 2018
-
-
Adry85 authored
-
- Jan 25, 2016
-
-
Zoey76 authored
Fixed minor typos.
-
- Aug 01, 2015
-
-
Zoey76 authored
Moving all files to main folder. Using Gradle to define, manage dependecies and build the project. Upgraded Gradle wrapper.
-
- Jan 02, 2015
-
-
Zoey76 authored
-
- Oct 31, 2014
-
-
UnAfraid authored
-
- Mar 01, 2014
-
-
Nos authored
-
- Feb 11, 2014
-
-
Nos authored
-
- Jan 24, 2014
-
-
Nos authored
Reviewed by: Zoey76, !UnAfraid
-
- Oct 27, 2013
-
-
Zoey76 authored
* Renamed `L2Effect` to `AbstractEffect`. * No more dynamic creation of effects (Huge performance and memory boost!). * Removed all traces or reflection on run time! * Removed `EffectTemplate`, merged with `AbstractEffect`. * Reworked and externalized all the logic from `AbstractEffect` that handled effect ticking. * Reviewed all "over time" skills: * `Flag` effect does not have ticks and doesn't need onActionTime() defined. * '''Fixed DOT (damage over time), MDOT (mana damage over time), HOT (heal over time), MHOT (mana heal over time) skills.''' * Reported by: Tavo22, Snip * `FakeDeath` effect should only last forever (or while conditions are met) if it's a toggle skill. * `Relax` effect should only last forever (or while conditions are met) if it's a toggle skill. * Removed `EffectState` enumerated and the nasty switch associated to it! * Removed "lambda" support from effects, the default attribute `val` is now double. * Removed val="0", now `val`'s default value is zero, no need to declare it explicitely. * '''Removed''' `noicon` '''attribute from effects, icon is not related to effects, but to the skill.'' * Renamed `AbnormalEffect` enumerated to `AbnormalVisualEffect`. * Removed `EffectDurationHolder` DTO. * Removed getFirstEffect(int), skills can be stoped by skill ID or `AbnormalType`. * Reworked (again) `CharEffectList`: * Using maps as underlying implementation, '''reduced drastically iterations''' (Hash tables offer 0(1) in most operations). * Using Javolution's `FastMap`, due Java lacks a default implementation that is ordered by insert order, thread-safe and concurrent safe. * Separated all kind of skills into buffs, triggers, dances, debuffs, passive. * Using Double-locked checking, useless instantiation of maps is avoided. * Improved buff counting operations (no more iterations over every effect every time you get a new one to know if you reached maximum count). * Removed getEffects() and all temporary list/map creations. * '''Reworked the way buffs are inserted preventing iterations and correcting exceptions while finding the correct index to insert the buff.''' * Reworked `Formulas`#calcEffectAbnormalTime(Env env) * Fixed `L2CubicInstance`#useCubic<Skill Type>(..), this methods are not static, then they don't need to recieve a `L2CubicInstance` as parameter. * Implemented `BuffInfo`, modeled from retail's implementation with minor changes to fit our implementation. * Complex DTO that holds all the information for a given buff (or debuff or dance/song) set of effects issued by an skill. * Controls the logic of the buffs. * Removed a few of `L2EffectType`. * Improved a bit `L2BabyPetInstance` skill casting related logic, reduced iterations and simplified the code. * Implemented `EffectTaskInfo`, DTO to hold the effect task (Maybe this will change later). * Implemented `EffectTickTask` runnable task to control ticking logic. * Removed "after effect" implementation, totally useless. * Suggested by: UnAfraid * Removed all the `L2Skill`#getEffects(..) methods replaced with L2Skill#applyEffects(..). * Moved "can be stolen" logic to `L2Skill`, it isn't related to the effect, but to the skill. * Added "Refresh" button on admin panel to check buffs easily. * Added admin command "admin_getbuff_ps" to check effects from passive skills. * Improved performance in `DispelBySlot` and `DispelBySlotProbability` effects. * Fixed minor typo in `DispelBySlot` and `DispelBySlotProbability` effects, there are values over `Byte.MAX_VALUE`. * '''Added retail support for Herbs, when a lesser buff is replaced by an herb, it becomes inactive, but it's timer continues, when the Herb buff finishes if the lesser buff has time it becomes active untill completes it's time.''' * Time does not pause, it just continues in the background. * Effects does not stack. * Reported by: Nos * '''Fixed Herbs, they shouldn't display gauge bar (casting bar) upon usage.''' * Reported by: Nos * '''Fixed Herbs not removing lesser effect icon, leading to players belive that buffs stack...''' * Reported by: Tavo22, evets, u3games, pandragon * '''Fixing instant effects being added to the effect list, and removing buffs present on the list.''' * Reported by: Tavo22 * '''Fixed "Short Buff" slot (slot for healing potions).''' * Statified reset packet (reduced object creation, a lot!). * Removed task to reset `ShortBuffStatusUpdate`, let's use buff ending task for that. * Moved logic to `CharEffectList` instead of `L2PcInstance` + `ItemSkillsTemplate`. * Reported by: JMD, Gries, Cresceus * Fixed `StealAbnormal` effect logic and `Formulas`#calcCancelStealEffects(..). * Improved buffs doesn't stack anymore with normal (lesser) buffs. * Now all effects are excecuted including instant effects (if they are successfuly applied). * Reported by: Adry_85 * `BlockChat` effect shouldn't be instant! * Fixed system messages related to skills (success, fail, removal, ending). * Improved `AdminBuffs`, more information is displayed: * Blocked abnormal skill types (if any) * Total buff count. * Hidden buff count. * Inactive effects (in red) * Skill level next to the name. * '''Rewritten''' `EffectMasterHandler` '''to avoid reflection where it's useless.''' * Since `L2EffectType` is scheduled to be removed: * `AbstractEffect`#getEffectType() is not abstract anymore, now returns L2EffectType.NONE by default. * '''Fixing debuffs working on "white players" with control.''' * Patch by: nBd (minor changes by Zoey76) * Reported by: plasan, jungla56, St3eT, Tavo22, Konstantinos, pandragon * '''Fixed exploit on restore summon feature that allows players to dupe summons.''' * Unhardcoding `canSummon` condition. * Reported by: Janiko * '''Fixed Arcane Shield getting stuck after being stolen.''' * Reported by: valanths1990, nBd, freestyler, Gries * '''Fixed triggered skills that got stacked within the same ID and different level.''' * Reported by: nBd, lucan, blacksea, Gries Tested by: Nos, Captain, Janiko, Konstantinos, Lucan, UnAfraid, Zoey76 '''Note to developers 1:''' Instant effects shouldn't override onExit(!BuffInfo). '''Note to developers 2:''' Is not required to call super.onStart() or super.onExit() to add/remove abnormal visual effects anymore, it's done on an indepent method. '''Note to developers 3:''' Do not add "steal constructor", such thing is not required anymore.
-
- Apr 27, 2013
-
-
Zoey76 authored
* Complete rework of !CharEffectList. * Mimicking "List" operations, remove(..), add(..), isEmpty()... * Thread-safe. * Using reentrant locks for read/write operations. * Removed cache-array, wasn't working. * Removed useless methods. * Removed queue, wrong implementation was leading to wrong updates in effect lists. * Now effects from skills are managed in batches, less calls to methods, avoiding overhead from synchronization and keeping abnormal type groups safe. * Support for blocked buff slots, no more hacks! * Implemented proper effect. * No more dependence on Javolution. * !JavaDocs! * Abnormal type, level and time are global to the skill and not specific to each effect. * Keeping support to customize each effect duration time, needs testing. * Added abnormal type enum, no more strings. * Removed overhead from string comparison. * !EffectTemplate rework: * No more public fields, we use mutators and accessors to work with them! * Func list to List instead of array. * Avoid CPU overhead, System.arraycopy(..). * Removed unused transform parameters. * !JavaDocs! * L2Skill rework: * No more dependence on Javolution. * Func and Effect lists to List instead of array. * Removed some useless effect type related method from skills. * Removed custom restriction for stolen effect with current duration less than 5 seconds. * If NPE appear they have to be properly fixed, no more hacks! * Updated toString() method. * !JavaDocs! * L2Effect rework: * Effects do not store static data from template! * Removed unused transform parameters. * Removed "passive effect" related methods, effect is passive if skill is passive. * Removed "buff"/"debuff" related method from effects, skills are buffs or debuffs not effects. * Updated toString() method. * Removed effectCanBeStolen() method, now canBeStolen() is overridden in effect implementations in Datapack. * !JavaDocs! * L2Item minor rework: * Func and Effect lists to List instead of array. * Avoid CPU overhead, System.arraycopy(..). * No more dependence on Javolution. * Now _questEvents is initialized only if it's used, not for all items! * L2Weapon fixes: * Fixed bug in getSkillEffects(L2Character, L2Character, L2Skill) returning always empty array of effects! * Func and Effect lists to List instead of array. * Avoid CPU overhead, System.arraycopy(..). * No more dependence on Javolution. * Reworked "get func" methods to avoid toArray(..) calls. * Proper use of maps, no more iteration over keys and retrieving the value using get method. * Externalized formula to calculate current effect duration to Formulas class. * Static fields are upper case. * Adding button to reload effects, '''must be follow by skill reload and probably player restart''' to ensure there is no memory-leftovers. * Fixing skill Frintezza's Songs(5008) abnormal types. * Fixing minor bug with High Five GM skills. * Added name to effect list from admin panel, fixed other minor glitches. * Removed old and classing GM menu. * Updated logs and comments. Reviewed by: Adry_85, MELERIX Testing video: http://youtu.be/7qadv7QQhy4
-
- Mar 27, 2013
-
-
Adry_85 authored
- Removed useless target type - Added support to affect limit for area skills - Replacing !FastList with !ArrayList Reviewed by: !UnAfraid, Zoey76 - Fixed Chain Heal issue with clan/ally targets Reported by: oscard Reviewed by: !UnAfraid
-
- Mar 24, 2013
-
-
MELERIX authored
'''NOTE: Require CORE [L5903]'''
-
- Jan 08, 2013
-
-
Zoey76 authored
* Proper GPLv3 license. * Updated all Java DP files. * Added missing license to the following files: * !FirstClassTransferTalk * !AdminInstanceZone * Updated Eclipse preferences for new files (header). * ''Same'' settings as Core.
-
- Nov 27, 2012
-
-
Adry_85 authored
* Avoiding some '''instanceof''' where it's possible. * Format and cleanup.
-
- May 30, 2012
-
-
Zoey76 authored
* Other warnings will be fixed later.
-
- Jan 24, 2012
-
-
Zoey76 authored
-
- Oct 24, 2011
-
-
MELERIX authored
-
- Oct 04, 2011
-
-
Zoey76 authored
* Renamed some method to match it's function. * Better Format setting for enums. '''Note:''' Require [4975].
-
- Sep 28, 2011
-
-
Zoey76 authored
* Added missing license to Java files. * Cleanup. * Set GPLv3 as default header for Java files.
-
- Sep 26, 2011
-
-
MELERIX authored
-
Rumen Nikiforov authored
-