BETA: Effect rework:
* Complete rework of !CharEffectList. * Mimicking "List" operations, remove(..), add(..), isEmpty()... * Thread-safe. * Using reentrant locks for read/write operations. * Removed cache-array, wasn't working. * Removed useless methods. * Removed queue, wrong implementation was leading to wrong updates in effect lists. * Now effects from skills are managed in batches, less calls to methods, avoiding overhead from synchronization and keeping abnormal type groups safe. * Support for blocked buff slots, no more hacks! * Implemented proper effect. * No more dependence on Javolution. * !JavaDocs! * Abnormal type, level and time are global to the skill and not specific to each effect. * Keeping support to customize each effect duration time, needs testing. * Added abnormal type enum, no more strings. * Removed overhead from string comparison. * !EffectTemplate rework: * No more public fields, we use mutators and accessors to work with them! * Func list to List instead of array. * Avoid CPU overhead, System.arraycopy(..). * Removed unused transform parameters. * !JavaDocs! * L2Skill rework: * No more dependence on Javolution. * Func and Effect lists to List instead of array. * Removed some useless effect type related method from skills. * Removed custom restriction for stolen effect with current duration less than 5 seconds. * If NPE appear they have to be properly fixed, no more hacks! * Updated toString() method. * !JavaDocs! * L2Effect rework: * Effects do not store static data from template! * Removed unused transform parameters. * Removed "passive effect" related methods, effect is passive if skill is passive. * Removed "buff"/"debuff" related method from effects, skills are buffs or debuffs not effects. * Updated toString() method. * Removed effectCanBeStolen() method, now canBeStolen() is overridden in effect implementations in Datapack. * !JavaDocs! * L2Item minor rework: * Func and Effect lists to List instead of array. * Avoid CPU overhead, System.arraycopy(..). * No more dependence on Javolution. * Now _questEvents is initialized only if it's used, not for all items! * L2Weapon fixes: * Fixed bug in getSkillEffects(L2Character, L2Character, L2Skill) returning always empty array of effects! * Func and Effect lists to List instead of array. * Avoid CPU overhead, System.arraycopy(..). * No more dependence on Javolution. * Reworked "get func" methods to avoid toArray(..) calls. * Proper use of maps, no more iteration over keys and retrieving the value using get method. * Externalized formula to calculate current effect duration to Formulas class. * Static fields are upper case. * Adding button to reload effects, '''must be follow by skill reload and probably player restart''' to ensure there is no memory-leftovers. * Fixing skill Frintezza's Songs(5008) abnormal types. * Fixing minor bug with High Five GM skills. * Added name to effect list from admin panel, fixed other minor glitches. * Removed old and classing GM menu. * Updated logs and comments. Reviewed by: Adry_85, MELERIX Testing video: http://youtu.be/7qadv7QQhy4
Showing
- L2J_DataPack_BETA/dist/game/config/adminCommands.xml 0 additions, 1 deletionL2J_DataPack_BETA/dist/game/config/adminCommands.xml
- L2J_DataPack_BETA/dist/game/data/html/admin/charinfo.htm 1 addition, 1 deletionL2J_DataPack_BETA/dist/game/data/html/admin/charinfo.htm
- L2J_DataPack_BETA/dist/game/data/html/admin/classic_menu.htm 0 additions, 45 deletionsL2J_DataPack_BETA/dist/game/data/html/admin/classic_menu.htm
- L2J_DataPack_BETA/dist/game/data/html/admin/old_menu.htm 0 additions, 79 deletionsL2J_DataPack_BETA/dist/game/data/html/admin/old_menu.htm
- L2J_DataPack_BETA/dist/game/data/html/admin/server_menu.htm 4 additions, 3 deletionsL2J_DataPack_BETA/dist/game/data/html/admin/server_menu.htm
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Amaskari.java 3 additions, 3 deletions...k_BETA/dist/game/data/scripts/ai/individual/Amaskari.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Baium.java 2 additions, 2 deletions...Pack_BETA/dist/game/data/scripts/ai/individual/Baium.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Valakas.java 2 additions, 2 deletions...ck_BETA/dist/game/data/scripts/ai/individual/Valakas.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Zaken.java 6 additions, 4 deletions...Pack_BETA/dist/game/data/scripts/ai/individual/Zaken.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/npc/NpcBuffers/CabaleBuffer.java 1 addition, 1 deletion...ist/game/data/scripts/ai/npc/NpcBuffers/CabaleBuffer.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/EffectMasterHandler.java 2 additions, 2 deletions.../dist/game/data/scripts/handlers/EffectMasterHandler.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/admincommandhandlers/AdminAdmin.java 1 addition, 12 deletions...ata/scripts/handlers/admincommandhandlers/AdminAdmin.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/admincommandhandlers/AdminBuffs.java 17 additions, 19 deletions...ata/scripts/handlers/admincommandhandlers/AdminBuffs.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/effecthandlers/AbortCast.java 1 addition, 1 deletion.../game/data/scripts/handlers/effecthandlers/AbortCast.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/effecthandlers/BlockBuffSlot.java 20 additions, 26 deletions...e/data/scripts/handlers/effecthandlers/BlockBuffSlot.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/effecthandlers/Bluff.java 1 addition, 1 deletion...dist/game/data/scripts/handlers/effecthandlers/Bluff.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/effecthandlers/Buff.java 1 addition, 1 deletion.../dist/game/data/scripts/handlers/effecthandlers/Buff.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/effecthandlers/CancelDebuff.java 4 additions, 2 deletions...me/data/scripts/handlers/effecthandlers/CancelDebuff.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/effecthandlers/ChameleonRest.java 0 additions, 6 deletions...e/data/scripts/handlers/effecthandlers/ChameleonRest.java
- L2J_DataPack_BETA/dist/game/data/scripts/handlers/effecthandlers/ChanceSkillTrigger.java 6 additions, 19 deletions...a/scripts/handlers/effecthandlers/ChanceSkillTrigger.java
Loading
Please register or sign in to comment