Skip to content
Snippets Groups Projects
  1. Sep 01, 2012
    • Zoey76's avatar
      BETA: Continuing with AI review: · 3f37dba6
      Zoey76 authored
      	* Do not use SkillTable.getInstance().getInfo(id, level) instead use SkillHolder DTO.
      		* Is possible to change the underlying implementation without reworking every single script.
      		* Avoids some problems during reloading.
      	* Static final variables should be upper case.
      	* Minimize the use of @formatter:off
      	* Use arrays of Location instead of arrays of arrays of int.
      	* Don't use literal values in the middle of the code, use static final variables for Ids, levels and other values.
      	* Document the code when something is not finished/retail like.
      		* When you work in open source is important to note that you knew it wasn't finished and let others know it as well.
      3f37dba6
    • malyelfik's avatar
      BETA: Improved quest '''Resurrection of an Old Manager''' · 65e2b34f
      malyelfik authored
      Suggested by: !UnAfraid
      65e2b34f
  2. Aug 31, 2012
  3. Aug 30, 2012
  4. Aug 28, 2012
  5. Aug 27, 2012
  6. Aug 26, 2012
  7. Aug 25, 2012
    • Adry_85's avatar
    • Adry_85's avatar
      40183b49
    • Rumen Nikiforov's avatar
      BETA: !//script_load improvements: · fe7ec485
      Rumen Nikiforov authored
      	* Now you can reload a script by name example:
      		* !//script_load Falk
      	* Cleanup.
      fe7ec485
    • Rumen Nikiforov's avatar
    • Adry_85's avatar
      BETA: Fixed '''Serenade of Eva''' power. · 96c82a1a
      Adry_85 authored
      96c82a1a
    • Ahmed's avatar
      BETA: Misc fixes: · ba97a4dc
      Ahmed authored
      1. Within !AdminBan.java:
      - '''(Style)''' String.equals("") is now replaced with String.isEmpty().
      (Avoid bad practice of returning true/false based on equating a String, instead use the strings length.)
      2. Within !BeastFarm.java, !EnergySeeds.java, !FeedableBeasts.java:
      - '''(Clean Up)''' Organized imports.
      3. Within ''Beleth.java'':
      - '''(Clean Up)''' Formatted to adhere to L2J code style.
      - '''(NPE)''' Within public void run(), there is a check to see if _npc is null or not, yet _npc.getAi... is outside this check. If _npc was indeed null, a null pointer exception would have occured.
      - '''(NPE)''' Within private static void deleteAll(), there is a check to see if minions is null or not, yet minions.clear() is outside this check. If minions was indeed null, a null pointer exception would have occured.
      - '''(Style)''' Initialization of static field's spawnTimer and belethKiller are now set by a setter i.e getters and setters.
      (Avoid writing to static from instance method's and bad initialization practice.)
      ba97a4dc
  8. Aug 24, 2012
Loading