BETA: Continuing with AI review:
* Do not use SkillTable.getInstance().getInfo(id, level) instead use SkillHolder DTO. * Is possible to change the underlying implementation without reworking every single script. * Avoids some problems during reloading. * Static final variables should be upper case. * Minimize the use of @formatter:off * Use arrays of Location instead of arrays of arrays of int. * Don't use literal values in the middle of the code, use static final variables for Ids, levels and other values. * Document the code when something is not finished/retail like. * When you work in open source is important to note that you knew it wasn't finished and let others know it as well.
Showing
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Baium.java 15 additions, 7 deletions...Pack_BETA/dist/game/data/scripts/ai/individual/Baium.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Beleth.java 18 additions, 18 deletions...ack_BETA/dist/game/data/scripts/ai/individual/Beleth.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/DarkWaterDragon.java 5 additions, 2 deletions...dist/game/data/scripts/ai/individual/DarkWaterDragon.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/DemonPrince.java 7 additions, 6 deletions...ETA/dist/game/data/scripts/ai/individual/DemonPrince.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/DrChaos.java 1 addition, 2 deletions...ck_BETA/dist/game/data/scripts/ai/individual/DrChaos.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/NaiaLock.java 2 additions, 1 deletion...k_BETA/dist/game/data/scripts/ai/individual/NaiaLock.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Orfen.java 5 additions, 7 deletions...Pack_BETA/dist/game/data/scripts/ai/individual/Orfen.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/OutpostCaptain.java 1 addition, 0 deletions.../dist/game/data/scripts/ai/individual/OutpostCaptain.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/QueenAnt.java 1 addition, 1 deletion...k_BETA/dist/game/data/scripts/ai/individual/QueenAnt.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/SinWardens.java 1 addition, 1 deletion...BETA/dist/game/data/scripts/ai/individual/SinWardens.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Typhoon.java 1 addition, 0 deletions...ck_BETA/dist/game/data/scripts/ai/individual/Typhoon.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Valakas.java 58 additions, 118 deletions...ck_BETA/dist/game/data/scripts/ai/individual/Valakas.java
- L2J_DataPack_BETA/dist/game/data/scripts/ai/individual/Zaken.java 4 additions, 8 deletions...Pack_BETA/dist/game/data/scripts/ai/individual/Zaken.java
Loading
Please register or sign in to comment