Skip to content
Snippets Groups Projects
Commit 3f37dba6 authored by Zoey76's avatar Zoey76
Browse files

BETA: Continuing with AI review:

	* Do not use SkillTable.getInstance().getInfo(id, level) instead use SkillHolder DTO.
		* Is possible to change the underlying implementation without reworking every single script.
		* Avoids some problems during reloading.
	* Static final variables should be upper case.
	* Minimize the use of @formatter:off
	* Use arrays of Location instead of arrays of arrays of int.
	* Don't use literal values in the middle of the code, use static final variables for Ids, levels and other values.
	* Document the code when something is not finished/retail like.
		* When you work in open source is important to note that you knew it wasn't finished and let others know it as well.
parent 65e2b34f
No related branches found
No related tags found
No related merge requests found
Showing
with 119 additions and 171 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment