- Oct 31, 2014
-
-
UnAfraid authored
-
- Mar 06, 2014
-
-
Nos authored
* Added a new parameter in skill xmls '''blockedInOlympiad'''. Reviewed by: Adry_85, St3eT
-
- Mar 01, 2014
-
-
Nos authored
-
- Feb 24, 2014
-
-
Nos authored
-
- Nov 03, 2013
-
-
Nos authored
Patch by: Nos, Adry_85 Reviewed by: Zoey76, !UnAfraid
-
- Oct 27, 2013
-
-
Zoey76 authored
* Renamed `L2Effect` to `AbstractEffect`. * No more dynamic creation of effects (Huge performance and memory boost!). * Removed all traces or reflection on run time! * Removed `EffectTemplate`, merged with `AbstractEffect`. * Reworked and externalized all the logic from `AbstractEffect` that handled effect ticking. * Reviewed all "over time" skills: * `Flag` effect does not have ticks and doesn't need onActionTime() defined. * '''Fixed DOT (damage over time), MDOT (mana damage over time), HOT (heal over time), MHOT (mana heal over time) skills.''' * Reported by: Tavo22, Snip * `FakeDeath` effect should only last forever (or while conditions are met) if it's a toggle skill. * `Relax` effect should only last forever (or while conditions are met) if it's a toggle skill. * Removed `EffectState` enumerated and the nasty switch associated to it! * Removed "lambda" support from effects, the default attribute `val` is now double. * Removed val="0", now `val`'s default value is zero, no need to declare it explicitely. * '''Removed''' `noicon` '''attribute from effects, icon is not related to effects, but to the skill.'' * Renamed `AbnormalEffect` enumerated to `AbnormalVisualEffect`. * Removed `EffectDurationHolder` DTO. * Removed getFirstEffect(int), skills can be stoped by skill ID or `AbnormalType`. * Reworked (again) `CharEffectList`: * Using maps as underlying implementation, '''reduced drastically iterations''' (Hash tables offer 0(1) in most operations). * Using Javolution's `FastMap`, due Java lacks a default implementation that is ordered by insert order, thread-safe and concurrent safe. * Separated all kind of skills into buffs, triggers, dances, debuffs, passive. * Using Double-locked checking, useless instantiation of maps is avoided. * Improved buff counting operations (no more iterations over every effect every time you get a new one to know if you reached maximum count). * Removed getEffects() and all temporary list/map creations. * '''Reworked the way buffs are inserted preventing iterations and correcting exceptions while finding the correct index to insert the buff.''' * Reworked `Formulas`#calcEffectAbnormalTime(Env env) * Fixed `L2CubicInstance`#useCubic<Skill Type>(..), this methods are not static, then they don't need to recieve a `L2CubicInstance` as parameter. * Implemented `BuffInfo`, modeled from retail's implementation with minor changes to fit our implementation. * Complex DTO that holds all the information for a given buff (or debuff or dance/song) set of effects issued by an skill. * Controls the logic of the buffs. * Removed a few of `L2EffectType`. * Improved a bit `L2BabyPetInstance` skill casting related logic, reduced iterations and simplified the code. * Implemented `EffectTaskInfo`, DTO to hold the effect task (Maybe this will change later). * Implemented `EffectTickTask` runnable task to control ticking logic. * Removed "after effect" implementation, totally useless. * Suggested by: UnAfraid * Removed all the `L2Skill`#getEffects(..) methods replaced with L2Skill#applyEffects(..). * Moved "can be stolen" logic to `L2Skill`, it isn't related to the effect, but to the skill. * Added "Refresh" button on admin panel to check buffs easily. * Added admin command "admin_getbuff_ps" to check effects from passive skills. * Improved performance in `DispelBySlot` and `DispelBySlotProbability` effects. * Fixed minor typo in `DispelBySlot` and `DispelBySlotProbability` effects, there are values over `Byte.MAX_VALUE`. * '''Added retail support for Herbs, when a lesser buff is replaced by an herb, it becomes inactive, but it's timer continues, when the Herb buff finishes if the lesser buff has time it becomes active untill completes it's time.''' * Time does not pause, it just continues in the background. * Effects does not stack. * Reported by: Nos * '''Fixed Herbs, they shouldn't display gauge bar (casting bar) upon usage.''' * Reported by: Nos * '''Fixed Herbs not removing lesser effect icon, leading to players belive that buffs stack...''' * Reported by: Tavo22, evets, u3games, pandragon * '''Fixing instant effects being added to the effect list, and removing buffs present on the list.''' * Reported by: Tavo22 * '''Fixed "Short Buff" slot (slot for healing potions).''' * Statified reset packet (reduced object creation, a lot!). * Removed task to reset `ShortBuffStatusUpdate`, let's use buff ending task for that. * Moved logic to `CharEffectList` instead of `L2PcInstance` + `ItemSkillsTemplate`. * Reported by: JMD, Gries, Cresceus * Fixed `StealAbnormal` effect logic and `Formulas`#calcCancelStealEffects(..). * Improved buffs doesn't stack anymore with normal (lesser) buffs. * Now all effects are excecuted including instant effects (if they are successfuly applied). * Reported by: Adry_85 * `BlockChat` effect shouldn't be instant! * Fixed system messages related to skills (success, fail, removal, ending). * Improved `AdminBuffs`, more information is displayed: * Blocked abnormal skill types (if any) * Total buff count. * Hidden buff count. * Inactive effects (in red) * Skill level next to the name. * '''Rewritten''' `EffectMasterHandler` '''to avoid reflection where it's useless.''' * Since `L2EffectType` is scheduled to be removed: * `AbstractEffect`#getEffectType() is not abstract anymore, now returns L2EffectType.NONE by default. * '''Fixing debuffs working on "white players" with control.''' * Patch by: nBd (minor changes by Zoey76) * Reported by: plasan, jungla56, St3eT, Tavo22, Konstantinos, pandragon * '''Fixed exploit on restore summon feature that allows players to dupe summons.''' * Unhardcoding `canSummon` condition. * Reported by: Janiko * '''Fixed Arcane Shield getting stuck after being stolen.''' * Reported by: valanths1990, nBd, freestyler, Gries * '''Fixed triggered skills that got stacked within the same ID and different level.''' * Reported by: nBd, lucan, blacksea, Gries Tested by: Nos, Captain, Janiko, Konstantinos, Lucan, UnAfraid, Zoey76 '''Note to developers 1:''' Instant effects shouldn't override onExit(!BuffInfo). '''Note to developers 2:''' Is not required to call super.onStart() or super.onExit() to add/remove abnormal visual effects anymore, it's done on an indepent method. '''Note to developers 3:''' Do not add "steal constructor", such thing is not required anymore.
-
- Jul 27, 2013
-
-
xban1x authored
* Reported by: u3games * Tested by: u3games * Reviewed by: jurchiks
-
- Jul 24, 2013
-
-
Rumen Nikiforov authored
* Patch by: Tan, UnAfraid, Nos
-
- Jun 17, 2013
-
-
Adry_85 authored
* Removed old and custom skillTypes and added new effects. * Added retail formula for effects '''!TargetCancel''', '''!TargetMeProbability''', '''!SkillTurning''', '''Betray''' and '''Bluff'''. * Patch by: Nos * Added all missing '''effectPoint''' inside skills. * Patch by: !UnAfraid * Fixed bug with !TargetMe effect that does not allow you to change target even if the effect has worn off. * Reported by: blacksea Reviewed by: Zoey76 Thanks to: Nos, !UnAfraid, Zoey76
-
- May 28, 2013
-
-
Rumen Nikiforov authored
* Also fixing typo in skill 2274 it have 8 levels not 9!
-
- May 26, 2013
-
-
Zoey76 authored
* Minor cleanup.
-
- May 17, 2013
-
-
Adry_85 authored
* Added new effect '''Escape''' and '''Teleport'''. * Added new condition !ConditionPlayerCanEscape. * Removed old skillTypes. Reviewed by: Zoey76
-
- Mar 27, 2013
-
-
Rumen Nikiforov authored
* '''Note:''' Be careful in future to do not break the sorting order. * Reviewed by: MELERIX, Zoey76, Adry_85
-
- Mar 24, 2013
-
-
MELERIX authored
'''NOTE: Require CORE [L5903]'''
-
- Nov 13, 2012
-
-
Adry_85 authored
-
- Nov 04, 2012
-
-
Zoey76 authored
* Fixed missing abnormal level attribute in skill Item Skill: Poison(3195). * Removed skill type in skill Switch State(6054). * Retail like skill Dismiss Agathion(3267). * Implemented all "Summon Agathion" skills retail like, using effect. * Implemented many missing "High Five Skill". * Implemented Summon Agathion effect. * Implemented Unsummon Agathion effect. * Effects cleanup. * Added many missing licenses.
-
- Sep 27, 2012
-
-
MELERIX authored
-
- Jun 03, 2012
- Jun 02, 2012
-
-
MELERIX authored
-
- Mar 05, 2012
-
-
MELERIX authored
BETA: Proper tags for task lists in skills (no more <!-- guess --> related comments), now you will see FIXME or TODO messages in Eclipse Task List (if you have xml tools installed http://www.l2jserver.com/forum/viewtopic.php?f=51&t=14539).
-
- Feb 09, 2012
-
-
Rumen Nikiforov authored
-
- Jan 26, 2012
-
-
Zoey76 authored
'''Note:''' All new active skills will have "A1" as default value, later some of them will be changed/updated.
-
- Dec 17, 2011
-
-
MELERIX authored
-
- Sep 26, 2011
-
-
MELERIX authored
-
- May 20, 2011
-
-
MELERIX authored
-
- Apr 20, 2011
-
-
Tan authored
No commit message
-
- Apr 16, 2011
- Apr 15, 2011
-
-
DrLecter authored
-