From 2edf5f2326739d624304995cfb0437e150ea23c2 Mon Sep 17 00:00:00 2001
From: Zoey76 <zoey_76@msn.com>
Date: Fri, 11 Dec 2015 00:35:42 -0200
Subject: [PATCH] Fixing minor typo preventing players from starting Into the
Large Cavern (179) quest
Minor cleanup.
---
.../scripts/custom/Validators/SubClassSkills.java | 2 +-
.../instances/DarkCloudMansion/DarkCloudMansion.java | 5 +----
.../Q00114_ResurrectionOfAnOldManager.java | 8 ++++----
.../Q00142_FallenAngelRequestOfDawn.java | 4 +++-
.../Q00179_IntoTheLargeCavern.java | 11 ++++++++---
.../Q00234_FatesWhisper/Q00234_FatesWhisper.java | 6 +++---
.../Q00246_PossessorOfAPreciousSoul3.java | 8 ++++----
.../Q00289_NoMoreSoupForYou.java | 4 ++--
.../Q00336_CoinsOfMagic/Q00336_CoinsOfMagic.java | 8 ++++----
.../Q00367_ElectrifyingRecharge.java | 2 +-
.../Q00386_StolenDignity/Q00386_StolenDignity.java | 4 ++--
.../Q00423_TakeYourBestShot.java | 4 ++--
12 files changed, 35 insertions(+), 31 deletions(-)
diff --git a/dist/game/data/scripts/custom/Validators/SubClassSkills.java b/dist/game/data/scripts/custom/Validators/SubClassSkills.java
index 7a9411ac0e..b2d5b9c446 100644
--- a/dist/game/data/scripts/custom/Validators/SubClassSkills.java
+++ b/dist/game/data/scripts/custom/Validators/SubClassSkills.java
@@ -139,7 +139,7 @@ public final class SubClassSkills extends Quest
cItems[i][1] = (int) Math.min(item.getCount(), Integer.MAX_VALUE);
}
- QuestState st = player.getQuestState("SubClassSkills");
+ QuestState st = getQuestState(player, false);
if (st == null)
{
st = newQuestState(player);
diff --git a/dist/game/data/scripts/instances/DarkCloudMansion/DarkCloudMansion.java b/dist/game/data/scripts/instances/DarkCloudMansion/DarkCloudMansion.java
index 73da3328ee..20e6a5705d 100644
--- a/dist/game/data/scripts/instances/DarkCloudMansion/DarkCloudMansion.java
+++ b/dist/game/data/scripts/instances/DarkCloudMansion/DarkCloudMansion.java
@@ -288,10 +288,7 @@ public final class DarkCloudMansion extends AbstractInstance
{
for (L2PcInstance partyMember : party.getMembers())
{
- if (partyMember.getQuestState(getName()) == null)
- {
- newQuestState(partyMember);
- }
+ getQuestState(partyMember, true);
world.addAllowed(partyMember.getObjectId());
teleportPlayer(partyMember, new Location(146534, 180464, -6117), world.getInstanceId());
}
diff --git a/dist/game/data/scripts/quests/Q00114_ResurrectionOfAnOldManager/Q00114_ResurrectionOfAnOldManager.java b/dist/game/data/scripts/quests/Q00114_ResurrectionOfAnOldManager/Q00114_ResurrectionOfAnOldManager.java
index 38289f784b..0e2f0a6e27 100644
--- a/dist/game/data/scripts/quests/Q00114_ResurrectionOfAnOldManager/Q00114_ResurrectionOfAnOldManager.java
+++ b/dist/game/data/scripts/quests/Q00114_ResurrectionOfAnOldManager/Q00114_ResurrectionOfAnOldManager.java
@@ -18,8 +18,6 @@
*/
package quests.Q00114_ResurrectionOfAnOldManager;
-import quests.Q00121_PavelTheGiant.Q00121_PavelTheGiant;
-
import com.l2jserver.gameserver.ai.CtrlIntention;
import com.l2jserver.gameserver.model.actor.L2Attackable;
import com.l2jserver.gameserver.model.actor.L2Character;
@@ -33,6 +31,8 @@ import com.l2jserver.gameserver.network.NpcStringId;
import com.l2jserver.gameserver.network.clientpackets.Say2;
import com.l2jserver.gameserver.network.serverpackets.NpcSay;
+import quests.Q00121_PavelTheGiant.Q00121_PavelTheGiant;
+
/**
* Resurrection of an Old Manager (114)<br>
* Original Jython script by Kerberos
@@ -80,7 +80,7 @@ public class Q00114_ResurrectionOfAnOldManager extends Quest
String htmltext = event;
switch (event)
{
- // Yumi
+ // Yumi
case "32041-04.htm":
st.startQuest();
break;
@@ -342,7 +342,7 @@ public class Q00114_ResurrectionOfAnOldManager extends Quest
{
if (creature.isPlayer())
{
- final QuestState st = creature.getActingPlayer().getQuestState(getName());
+ final QuestState st = getQuestState(creature.getActingPlayer(), false);
if ((st != null) && st.isCond(17))
{
st.takeItems(DETCTOR, 1);
diff --git a/dist/game/data/scripts/quests/Q00142_FallenAngelRequestOfDawn/Q00142_FallenAngelRequestOfDawn.java b/dist/game/data/scripts/quests/Q00142_FallenAngelRequestOfDawn/Q00142_FallenAngelRequestOfDawn.java
index a5614f7bea..59ef15dc75 100644
--- a/dist/game/data/scripts/quests/Q00142_FallenAngelRequestOfDawn/Q00142_FallenAngelRequestOfDawn.java
+++ b/dist/game/data/scripts/quests/Q00142_FallenAngelRequestOfDawn/Q00142_FallenAngelRequestOfDawn.java
@@ -42,6 +42,7 @@ public class Q00142_FallenAngelRequestOfDawn extends Quest
// Monsters
private static final int FALLEN_ANGEL = 27338;
private static final Map<Integer, Integer> MOBS = new HashMap<>();
+
static
{
MOBS.put(20079, 338); // Ant
@@ -55,6 +56,7 @@ public class Q00142_FallenAngelRequestOfDawn extends Quest
MOBS.put(20089, 431); // Noble Ant
MOBS.put(20090, 917); // Noble Ant Leader
}
+
// Items
private static final int CRYPTOGRAM_OF_THE_ANGEL_SEARCH = 10351;
private static final int PROPHECY_FRAGMENT = 10352;
@@ -138,7 +140,7 @@ public class Q00142_FallenAngelRequestOfDawn extends Quest
final QuestState st;
if ((npc.getId() == FALLEN_ANGEL))
{
- st = player.getQuestState(getName());
+ st = getQuestState(player, false);
if (st.isCond(5))
{
st.giveItems(FALLEN_ANGEL_BLOOD, 1);
diff --git a/dist/game/data/scripts/quests/Q00179_IntoTheLargeCavern/Q00179_IntoTheLargeCavern.java b/dist/game/data/scripts/quests/Q00179_IntoTheLargeCavern/Q00179_IntoTheLargeCavern.java
index 982e8030bc..988baa4f3d 100644
--- a/dist/game/data/scripts/quests/Q00179_IntoTheLargeCavern/Q00179_IntoTheLargeCavern.java
+++ b/dist/game/data/scripts/quests/Q00179_IntoTheLargeCavern/Q00179_IntoTheLargeCavern.java
@@ -25,6 +25,8 @@ import com.l2jserver.gameserver.model.quest.Quest;
import com.l2jserver.gameserver.model.quest.QuestState;
import com.l2jserver.gameserver.model.quest.State;
+import quests.Q00178_IconicTrinity.Q00178_IconicTrinity;
+
/**
* Into the Large Cavern (179)
* @author Gnacik
@@ -35,6 +37,9 @@ public class Q00179_IntoTheLargeCavern extends Quest
// NPCs
private static final int KEKROPUS = 32138;
private static final int MENACING_MACHINE = 32258;
+ // Misc
+ private static final int MIN_LEVEL = 17;
+ private static final int MAX_LEVEL = 21;
public Q00179_IntoTheLargeCavern()
{
@@ -100,13 +105,13 @@ public class Q00179_IntoTheLargeCavern extends Quest
}
else
{
- final QuestState prev = player.getQuestState("178_IconicTrinity");
+ final QuestState prev = player.getQuestState(Q00178_IconicTrinity.class.getSimpleName());
final int level = player.getLevel();
- if ((prev != null) && prev.isCompleted() && (level >= 17) && (level <= 21) && (player.getClassId().level() == 0))
+ if ((prev != null) && prev.isCompleted() && (level >= MIN_LEVEL) && (level <= MAX_LEVEL) && (player.getClassId().level() == 0))
{
htmltext = "32138-01.htm";
}
- else if (level < 17)
+ else if (level < MIN_LEVEL)
{
htmltext = "32138-00.html";
}
diff --git a/dist/game/data/scripts/quests/Q00234_FatesWhisper/Q00234_FatesWhisper.java b/dist/game/data/scripts/quests/Q00234_FatesWhisper/Q00234_FatesWhisper.java
index 3af2fc2841..5e89c68868 100644
--- a/dist/game/data/scripts/quests/Q00234_FatesWhisper/Q00234_FatesWhisper.java
+++ b/dist/game/data/scripts/quests/Q00234_FatesWhisper/Q00234_FatesWhisper.java
@@ -1121,7 +1121,7 @@ public final class Q00234_FatesWhisper extends Quest
@Override
public String onAttack(L2Npc npc, L2PcInstance attacker, int damage, boolean isSummon)
{
- QuestState qs = attacker.getQuestState(getName());
+ QuestState qs = getQuestState(attacker, false);
if ((qs != null) && (npc.getId() == BAIUM))
{
if ((attacker.getActiveWeaponItem() != null) && (attacker.getActiveWeaponItem().getId() == Q_PIPETTE_KNIFE))
@@ -1137,7 +1137,7 @@ public final class Q00234_FatesWhisper extends Quest
private QuestState getRandomPlayerFromParty(L2PcInstance player, L2Npc npc, int memoState)
{
- QuestState qs = player.getQuestState(getName());
+ QuestState qs = getQuestState(player, false);
final List<QuestState> candidates = new ArrayList<>();
if ((qs != null) && qs.isStarted() && (qs.getMemoState() == memoState) && !qs.hasQuestItems(Q_WHITE_FABRIC_Q0234))
@@ -1151,7 +1151,7 @@ public final class Q00234_FatesWhisper extends Quest
player.getParty().getMembers().stream().forEach(pm ->
{
- QuestState qss = pm.getQuestState(getName());
+ QuestState qss = getQuestState(pm, false);
if ((qss != null) && qss.isStarted() && (qss.getMemoState() == memoState) && !qss.hasQuestItems(Q_WHITE_FABRIC_Q0234) && Util.checkIfInRange(1500, npc, pm, true))
{
candidates.add(qss);
diff --git a/dist/game/data/scripts/quests/Q00246_PossessorOfAPreciousSoul3/Q00246_PossessorOfAPreciousSoul3.java b/dist/game/data/scripts/quests/Q00246_PossessorOfAPreciousSoul3/Q00246_PossessorOfAPreciousSoul3.java
index 319d969a08..8b6c079701 100644
--- a/dist/game/data/scripts/quests/Q00246_PossessorOfAPreciousSoul3/Q00246_PossessorOfAPreciousSoul3.java
+++ b/dist/game/data/scripts/quests/Q00246_PossessorOfAPreciousSoul3/Q00246_PossessorOfAPreciousSoul3.java
@@ -18,8 +18,6 @@
*/
package quests.Q00246_PossessorOfAPreciousSoul3;
-import quests.Q00242_PossessorOfAPreciousSoul2.Q00242_PossessorOfAPreciousSoul2;
-
import com.l2jserver.gameserver.enums.QuestSound;
import com.l2jserver.gameserver.model.actor.L2Npc;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
@@ -28,6 +26,8 @@ import com.l2jserver.gameserver.model.quest.QuestState;
import com.l2jserver.gameserver.model.quest.State;
import com.l2jserver.gameserver.util.Util;
+import quests.Q00242_PossessorOfAPreciousSoul2.Q00242_PossessorOfAPreciousSoul2;
+
/**
* Possessor Of A PreciousSoul part 3 (246)<br>
* Original Jython script by disKret.
@@ -212,7 +212,7 @@ public class Q00246_PossessorOfAPreciousSoul3 extends Quest
}
else
{
- pst = player.getQuestState(getName());
+ pst = getQuestState(player, false);
if (pst != null)
{
if (pst.isCond(4) && !pst.hasQuestItems(RAIN_SONG))
@@ -224,7 +224,7 @@ public class Q00246_PossessorOfAPreciousSoul3 extends Quest
}
break;
default:
- st = player.getQuestState(getName());
+ st = getQuestState(player, false);
if ((st == null))
{
return super.onKill(npc, player, isSummon);
diff --git a/dist/game/data/scripts/quests/Q00289_NoMoreSoupForYou/Q00289_NoMoreSoupForYou.java b/dist/game/data/scripts/quests/Q00289_NoMoreSoupForYou/Q00289_NoMoreSoupForYou.java
index 30b824c99d..8ccc2f378d 100644
--- a/dist/game/data/scripts/quests/Q00289_NoMoreSoupForYou/Q00289_NoMoreSoupForYou.java
+++ b/dist/game/data/scripts/quests/Q00289_NoMoreSoupForYou/Q00289_NoMoreSoupForYou.java
@@ -248,8 +248,8 @@ public class Q00289_NoMoreSoupForYou extends Quest
switch (st.getState())
{
case State.CREATED:
- QuestState _prev = player.getQuestState(Q00252_ItSmellsDelicious.class.getSimpleName());
- htmltext = ((_prev != null) && _prev.isCompleted() && (player.getLevel() >= 82)) ? "30200-01.htm" : "30200-00.htm";
+ QuestState qs252 = player.getQuestState(Q00252_ItSmellsDelicious.class.getSimpleName());
+ htmltext = ((qs252 != null) && qs252.isCompleted() && (player.getLevel() >= 82)) ? "30200-01.htm" : "30200-00.htm";
break;
case State.STARTED:
if (st.isCond(1))
diff --git a/dist/game/data/scripts/quests/Q00336_CoinsOfMagic/Q00336_CoinsOfMagic.java b/dist/game/data/scripts/quests/Q00336_CoinsOfMagic/Q00336_CoinsOfMagic.java
index 29f352ba10..6ca8aa3aa5 100644
--- a/dist/game/data/scripts/quests/Q00336_CoinsOfMagic/Q00336_CoinsOfMagic.java
+++ b/dist/game/data/scripts/quests/Q00336_CoinsOfMagic/Q00336_CoinsOfMagic.java
@@ -1793,7 +1793,7 @@ public final class Q00336_CoinsOfMagic extends Quest
private QuestState getRandomPlayerFromParty(L2PcInstance player, L2Npc npc, int memoState)
{
- QuestState qs = player.getQuestState(getName());
+ QuestState qs = getQuestState(player, false);
final List<QuestState> candidates = new ArrayList<>();
if ((qs != null) && qs.isStarted() && (qs.getMemoState() == memoState))
@@ -1807,7 +1807,7 @@ public final class Q00336_CoinsOfMagic extends Quest
player.getParty().getMembers().stream().forEach(pm ->
{
- QuestState qss = pm.getQuestState(getName());
+ QuestState qss = getQuestState(pm, false);
if ((qss != null) && qss.isStarted() && (qss.getMemoState() == memoState) && Util.checkIfInRange(1500, npc, pm, true))
{
candidates.add(qss);
@@ -1819,7 +1819,7 @@ public final class Q00336_CoinsOfMagic extends Quest
private QuestState getRandomPlayerFromPartyCoin(L2PcInstance player, L2Npc npc, int memoState)
{
- QuestState qs = player.getQuestState(getName());
+ QuestState qs = getQuestState(player, false);
final List<QuestState> candidates = new ArrayList<>();
if ((qs != null) && qs.isStarted() && (qs.getMemoState() == memoState) && !qs.hasQuestItems(Q_KALDIS_GOLD_DRAGON))
{
@@ -1832,7 +1832,7 @@ public final class Q00336_CoinsOfMagic extends Quest
player.getParty().getMembers().stream().forEach(pm ->
{
- QuestState qss = pm.getQuestState(getName());
+ QuestState qss = getQuestState(pm, false);
if ((qss != null) && qss.isStarted() && (qss.getMemoState() == memoState) && !qss.hasQuestItems(Q_KALDIS_GOLD_DRAGON) && Util.checkIfInRange(1500, npc, pm, true))
{
candidates.add(qss);
diff --git a/dist/game/data/scripts/quests/Q00367_ElectrifyingRecharge/Q00367_ElectrifyingRecharge.java b/dist/game/data/scripts/quests/Q00367_ElectrifyingRecharge/Q00367_ElectrifyingRecharge.java
index 23967af036..0484a28822 100644
--- a/dist/game/data/scripts/quests/Q00367_ElectrifyingRecharge/Q00367_ElectrifyingRecharge.java
+++ b/dist/game/data/scripts/quests/Q00367_ElectrifyingRecharge/Q00367_ElectrifyingRecharge.java
@@ -149,7 +149,7 @@ public final class Q00367_ElectrifyingRecharge extends Quest
{
giveItems(luckyPlayer, TITAN_LAMP5, 1);
takeItems(luckyPlayer, TITAN_LAMP4, -1);
- luckyPlayer.getQuestState(getName()).setCond(2, true);
+ getQuestState(luckyPlayer, false).setCond(2, true);
}
}
else if ((random == 1) && !hasQuestItems(luckyPlayer, BROKEN_TITAN_LAMP))
diff --git a/dist/game/data/scripts/quests/Q00386_StolenDignity/Q00386_StolenDignity.java b/dist/game/data/scripts/quests/Q00386_StolenDignity/Q00386_StolenDignity.java
index f2cd3ed50b..26289bb6f6 100644
--- a/dist/game/data/scripts/quests/Q00386_StolenDignity/Q00386_StolenDignity.java
+++ b/dist/game/data/scripts/quests/Q00386_StolenDignity/Q00386_StolenDignity.java
@@ -873,7 +873,7 @@ public final class Q00386_StolenDignity extends Quest
private QuestState getRandomPlayerFromParty(L2PcInstance player, L2Npc npc)
{
- QuestState qs = player.getQuestState(getName());
+ QuestState qs = getQuestState(player, false);
final List<QuestState> candidates = new ArrayList<>();
if ((qs != null) && qs.isStarted())
@@ -887,7 +887,7 @@ public final class Q00386_StolenDignity extends Quest
player.getParty().getMembers().stream().forEach(pm ->
{
- QuestState qss = pm.getQuestState(getName());
+ QuestState qss = getQuestState(pm, false);
if ((qss != null) && qss.isStarted() && Util.checkIfInRange(1500, npc, pm, true))
{
candidates.add(qss);
diff --git a/dist/game/data/scripts/quests/Q00423_TakeYourBestShot/Q00423_TakeYourBestShot.java b/dist/game/data/scripts/quests/Q00423_TakeYourBestShot/Q00423_TakeYourBestShot.java
index f92a879ffa..a8da2d073d 100644
--- a/dist/game/data/scripts/quests/Q00423_TakeYourBestShot/Q00423_TakeYourBestShot.java
+++ b/dist/game/data/scripts/quests/Q00423_TakeYourBestShot/Q00423_TakeYourBestShot.java
@@ -122,8 +122,8 @@ public class Q00423_TakeYourBestShot extends Quest
switch (st.getState())
{
case State.CREATED:
- final QuestState _prev = player.getQuestState(Q00249_PoisonedPlainsOfTheLizardmen.class.getSimpleName());
- if ((_prev != null) && _prev.isCompleted() && (player.getLevel() >= MIN_LEVEL))
+ final QuestState qs249 = player.getQuestState(Q00249_PoisonedPlainsOfTheLizardmen.class.getSimpleName());
+ if ((qs249 != null) && qs249.isCompleted() && (player.getLevel() >= MIN_LEVEL))
{
htmltext = (st.hasQuestItems(SEER_UGOROS_PASS)) ? "32744-07.htm" : "32744-01.htm";
}
--
GitLab